From 4980714583a4a53f87996dc05253d9fad814c42e Mon Sep 17 00:00:00 2001 From: Tyler Koenig Date: Sun, 17 May 2026 14:10:40 -0400 Subject: [PATCH] fix(api): check http errors before using response in tests --- internal/api/api_test.go | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/internal/api/api_test.go b/internal/api/api_test.go index 862e5af..7f10aa1 100644 --- a/internal/api/api_test.go +++ b/internal/api/api_test.go @@ -630,7 +630,10 @@ func TestUpdateEntity_Title(t *testing.T) { req, _ := http.NewRequest("PUT", srv.URL+"/api/entities/"+created.ID, bytes.NewReader( mustJSON(map[string]any{"title": "new title"}))) req.Header.Set("Content-Type", "application/json") - resp, _ := http.DefaultClient.Do(req) + resp, err := http.DefaultClient.Do(req) + if err != nil { + t.Fatalf("request failed: %v", err) + } defer resp.Body.Close() if resp.StatusCode != http.StatusOK { @@ -651,7 +654,10 @@ func TestUpdateEntity_Description(t *testing.T) { req, _ := http.NewRequest("PUT", srv.URL+"/api/entities/"+created.ID, bytes.NewReader( mustJSON(map[string]any{"description": "new desc"}))) req.Header.Set("Content-Type", "application/json") - resp, _ := http.DefaultClient.Do(req) + resp, err := http.DefaultClient.Do(req) + if err != nil { + t.Fatalf("request failed: %v", err) + } defer resp.Body.Close() if resp.StatusCode != http.StatusOK { @@ -674,7 +680,10 @@ func TestListEntities_TitleInResponse(t *testing.T) { "title": title, }).Body.Close() - resp, _ := http.Get(srv.URL + "/api/entities") + resp, err := http.Get(srv.URL + "/api/entities") + if err != nil { + t.Fatalf("request failed: %v", err) + } defer resp.Body.Close() var entities []EntityResponse