lerko/nib-v1
1
1
Fork 0
Code Issues Pull Requests 2 Actions Packages Projects Releases Wiki Activity

fix: code principles audit — correctness, security, test-ability #5

Merged
lerko merged 1 commits from fix/code-principles-audit into develop 2026-05-14 21:55:27 +00:00
Conversation 0 Commits 1 Files Changed 12
+500 -104
lerko commented 2026-05-14 21:55:20 +00:00
Owner
Copy Link
Copy Source
  • Add rows.Err() checks after all scan loops (entities, tags, resolve)
  • Surface time.Parse errors instead of silently discarding
  • Extract entityRow scan helper to eliminate Get/List duplication
  • Cap request body at 1MB via MaxBytesReader
  • Stop leaking internal errors to API clients (log server-side only)
  • Block javascript: URIs in link card open button (XSS)
  • Fix all go vet failures in api_test.go (unchecked http errors)
  • Add tests for display package, generateCardData, absorb-source-card
  • Run go mod tidy to fix direct/indirect dep markers
- Add rows.Err() checks after all scan loops (entities, tags, resolve) - Surface time.Parse errors instead of silently discarding - Extract entityRow scan helper to eliminate Get/List duplication - Cap request body at 1MB via MaxBytesReader - Stop leaking internal errors to API clients (log server-side only) - Block javascript: URIs in link card open button (XSS) - Fix all go vet failures in api_test.go (unchecked http errors) - Add tests for display package, generateCardData, absorb-source-card - Run go mod tidy to fix direct/indirect dep markers
lerko added 1 commit 2026-05-14 21:55:20 +00:00
fix: code principles audit — correctness, security, testability 6278cb1022 
- Add rows.Err() checks after all scan loops (entities, tags, resolve)
- Surface time.Parse errors instead of silently discarding
- Extract entityRow scan helper to eliminate Get/List duplication
- Cap request body at 1MB via MaxBytesReader
- Stop leaking internal errors to API clients (log server-side only)
- Block javascript: URIs in link card open button (XSS)
- Fix all go vet failures in api_test.go (unchecked http errors)
- Add tests for display package, generateCardData, absorb-source-card
- Run go mod tidy to fix direct/indirect dep markers
lerko merged commit e477e8d512 into develop 2026-05-14 21:55:27 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Bug
Feature
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
lerko (Tyler Koenig)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lerko/nib-v1#5
Delete Branch "fix/code-principles-audit"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?