lerkolabs/uptop
1
1
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases 2 Wiki Activity

fix(tui): scope form validators to relevant monitor types #23

Merged
lerko merged 2 commits from fix/ssl-threshold-validation into main 2026-05-24 22:03:33 +00:00
Conversation 0 Commits 2 Files Changed 1
+12 -3
lerko commented 2026-05-24 21:46:07 +00:00
Owner
Copy Link
Copy Source

Summary

  • URL validation now only fires for http type monitors (was blocking ping/tcp/dns edits)
  • SSL threshold validation skips when CheckSSL is disabled (was blocking non-HTTPS site edits)
  • Port validation only fires for port type monitors
  • Max retries validator guards against group type for consistency

Test plan

  • Edit a ping monitor — should not block on URL field
  • Edit an HTTP site with CheckSSL=false — should not block on SSL threshold
  • Edit a group monitor — no validators should fire on hidden fields
## Summary - URL validation now only fires for `http` type monitors (was blocking ping/tcp/dns edits) - SSL threshold validation skips when CheckSSL is disabled (was blocking non-HTTPS site edits) - Port validation only fires for `port` type monitors - Max retries validator guards against group type for consistency ## Test plan - [ ] Edit a ping monitor — should not block on URL field - [ ] Edit an HTTP site with CheckSSL=false — should not block on SSL threshold - [ ] Edit a group monitor — no validators should fire on hidden fields
lerko added 2 commits 2026-05-24 21:46:07 +00:00
fix(tui): skip irrelevant field validation by monitor type b5b9cc81a5 
URL, SSL threshold, and port validators blocked form progression
when editing monitors that don't use those fields (e.g. ping monitors
failing URL validation, non-SSL sites failing threshold check).

Scope each validator to fire only for its relevant monitor type.
fix(tui): guard max retries validator for group type
CI / test (pull_request) Successful in 4m40s
Details
CI / lint (pull_request) Successful in 1m1s
Details
0a56f01929 
Consistent with interval/timeout validators that already skip for
group monitors. Prevents potential validation block if field is
cleared while editing.
lerko merged commit 6e659cf6ee into main 2026-05-24 22:03:33 +00:00
lerko deleted branch fix/ssl-threshold-validation 2026-05-24 22:03:33 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
lerko (Tyler Koenig)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lerkolabs/uptop#23
Delete Branch "fix/ssl-threshold-validation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?