refactor: extract magic numbers to named constants
CI / test (pull_request) Successful in 1m43s
CI / lint (pull_request) Successful in 1m17s
CI / vulncheck (pull_request) Successful in 51s

Replace inline numeric literals with named constants across 14 files:
server timeouts/rate limits, cluster thresholds/intervals, DB pool
sizes, alert/dial timeouts, TUI uptime thresholds, node status
thresholds, and state history limits.
This commit was merged in pull request #153.
This commit is contained in:
2026-06-27 15:44:03 -04:00
parent edbc2beddd
commit 50f77da131
15 changed files with 108 additions and 50 deletions
+10 -4
View File
@@ -38,14 +38,20 @@ func Start(ctx context.Context, cfg Config, eng *monitor.Engine) {
// "probe" mode is handled directly in main.go before cluster.Start is called
}
const (
followerTimeout = 2 * time.Second
leaderFailureThreshold = 3
followerRetryInterval = 5 * time.Second
)
func runFollowerLoop(ctx context.Context, cfg Config, eng *monitor.Engine) {
client := http.Client{Timeout: 2 * time.Second}
client := http.Client{Timeout: followerTimeout}
failures := 0
threshold := 3
threshold := leaderFailureThreshold
for {
select {
case <-time.After(5 * time.Second):
case <-time.After(followerRetryInterval):
case <-ctx.Done():
return
}
@@ -59,7 +65,7 @@ func runFollowerLoop(ctx context.Context, cfg Config, eng *monitor.Engine) {
isLeaderHealthy := false
if err == nil {
isLeaderHealthy = resp.StatusCode == 200
isLeaderHealthy = resp.StatusCode == http.StatusOK
_ = resp.Body.Close()
}
+9 -3
View File
@@ -26,12 +26,18 @@ type ProbeConfig struct {
AllowPrivateTargets bool
}
const (
probeMinInterval = 10
probeDefaultInterval = 30
probeAPITimeout = 10 * time.Second
)
func RunProbe(ctx context.Context, cfg ProbeConfig) error {
if cfg.Interval < 10 {
cfg.Interval = 30
if cfg.Interval < probeMinInterval {
cfg.Interval = probeDefaultInterval
}
apiClient := &http.Client{Timeout: 10 * time.Second}
apiClient := &http.Client{Timeout: probeAPITimeout}
dial := monitor.SafeDialContext(cfg.AllowPrivateTargets)
strictClient := &http.Client{
Transport: &http.Transport{