lerkolabs/uptop
1
1
Fork 0
Code Issues 17 Pull Requests 1 Actions Packages Projects 2 Releases 1 Wiki Activity

refactor(monitor): extract magic numbers into named constants

Browse Source 
Closes #75
This commit is contained in:
Tyler Koenig
2026-06-05 16:30:38 -04:00
parent 965a864343
commit b44b7832ff
2 changed files with 18 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/monitor/checker.go
+17 -7
View File
@@ -15,6 +15,16 @@ import (
probing "github.com/prometheus-community/pro-bing" probing "github.com/prometheus-community/pro-bing"
) )
const (
maxErrorLength = 256
defaultAcceptedCodes = "200-299"
defaultHTTPStatusMin = 200
defaultHTTPStatusMax = 300
defaultTimeout = 5 * time.Second
defaultDNSServer = "1.1.1.1"
defaultDNSPort = "53"
)
type CheckResult struct { type CheckResult struct {
SiteID int SiteID int
Status string // "UP", "DOWN", "SSL EXP" Status string // "UP", "DOWN", "SSL EXP"
@@ -90,7 +100,7 @@ func runHTTPCheck(site models.Site, strict, insecure *http.Client, globalInsecur
if err != nil { if err != nil {
result.Status = "DOWN" result.Status = "DOWN"
result.ErrorReason = truncateError(err.Error(), 256) result.ErrorReason = truncateError(err.Error(), maxErrorLength)
return result return result
} }
defer resp.Body.Close() defer resp.Body.Close()
@@ -100,7 +110,7 @@ func runHTTPCheck(site models.Site, strict, insecure *http.Client, globalInsecur
result.Status = "DOWN" result.Status = "DOWN"
expected := site.AcceptedCodes expected := site.AcceptedCodes
if expected == "" { if expected == "" {
expected = "200-299" expected = defaultAcceptedCodes
} }
result.ErrorReason = fmt.Sprintf("HTTP %d (expected %s)", resp.StatusCode, expected) result.ErrorReason = fmt.Sprintf("HTTP %d (expected %s)", resp.StatusCode, expected)
} }
@@ -160,7 +170,7 @@ func runPortCheck(site models.Site) CheckResult {
latency := time.Since(start) latency := time.Since(start)
if err != nil { if err != nil {
return CheckResult{SiteID: site.ID, Status: "DOWN", LatencyNs: latency.Nanoseconds(), ErrorReason: truncateError(err.Error(), 256)} return CheckResult{SiteID: site.ID, Status: "DOWN", LatencyNs: latency.Nanoseconds(), ErrorReason: truncateError(err.Error(), maxErrorLength)}
} }
_ = conn.Close() _ = conn.Close()
return CheckResult{SiteID: site.ID, Status: "UP", LatencyNs: latency.Nanoseconds()} return CheckResult{SiteID: site.ID, Status: "UP", LatencyNs: latency.Nanoseconds()}
@@ -174,10 +184,10 @@ func runDNSCheck(site models.Site) CheckResult {
server := site.DNSServer server := site.DNSServer
if server == "" { if server == "" {
server = "1.1.1.1" server = defaultDNSServer
} }
if _, _, err := net.SplitHostPort(server); err != nil { if _, _, err := net.SplitHostPort(server); err != nil {
server = net.JoinHostPort(server, "53") server = net.JoinHostPort(server, defaultDNSPort)
} }
qtype := dns.TypeA qtype := dns.TypeA
@@ -223,12 +233,12 @@ func siteTimeout(site models.Site) time.Duration {
if site.Timeout > 0 { if site.Timeout > 0 {
return time.Duration(site.Timeout) * time.Second return time.Duration(site.Timeout) * time.Second
} }
return 5 * time.Second return defaultTimeout
} }
func isCodeAccepted(code int, accepted string) bool { func isCodeAccepted(code int, accepted string) bool {
if accepted == "" { if accepted == "" {
return code >= 200 && code < 300 return code >= defaultHTTPStatusMin && code < defaultHTTPStatusMax
} }
for _, part := range strings.Split(accepted, ",") { for _, part := range strings.Split(accepted, ",") {
part = strings.TrimSpace(part) part = strings.TrimSpace(part)
internal/monitor/monitor.go
+1 -1
View File
@@ -138,7 +138,7 @@ func (e *Engine) AddLog(msg string) {
} }
func (e *Engine) InitLogs() { func (e *Engine) InitLogs() {
logs, err := e.db.LoadLogs(100) logs, err := e.db.LoadLogs(maxLogEntries)
if err != nil { if err != nil {
return return
} }