From d53a4e6ac30cafff3abf650e3de4ea74016544d3 Mon Sep 17 00:00:00 2001
From: Tyler Koenig <tyler@lerkolabs.com>
Date: Fri, 5 Jun 2026 16:30:38 -0400
Subject: [PATCH] refactor(monitor): extract magic numbers into named constants

Closes #75
---
 internal/monitor/checker.go | 24 +++++++++++++++++-------
 internal/monitor/monitor.go |  2 +-
 2 files changed, 18 insertions(+), 8 deletions(-)

diff --git a/internal/monitor/checker.go b/internal/monitor/checker.go
index 5ce2720..5ed3f3a 100644
--- a/internal/monitor/checker.go
+++ b/internal/monitor/checker.go
@@ -15,6 +15,16 @@ import (
 	probing "github.com/prometheus-community/pro-bing"
 )
 
+const (
+	maxErrorLength       = 256
+	defaultAcceptedCodes = "200-299"
+	defaultHTTPStatusMin = 200
+	defaultHTTPStatusMax = 300
+	defaultTimeout       = 5 * time.Second
+	defaultDNSServer     = "1.1.1.1"
+	defaultDNSPort       = "53"
+)
+
 type CheckResult struct {
 	SiteID      int
 	Status      string // "UP", "DOWN", "SSL EXP"
@@ -90,7 +100,7 @@ func runHTTPCheck(site models.Site, strict, insecure *http.Client, globalInsecur
 
 	if err != nil {
 		result.Status = "DOWN"
-		result.ErrorReason = truncateError(err.Error(), 256)
+		result.ErrorReason = truncateError(err.Error(), maxErrorLength)
 		return result
 	}
 	defer resp.Body.Close()
@@ -100,7 +110,7 @@ func runHTTPCheck(site models.Site, strict, insecure *http.Client, globalInsecur
 		result.Status = "DOWN"
 		expected := site.AcceptedCodes
 		if expected == "" {
-			expected = "200-299"
+			expected = defaultAcceptedCodes
 		}
 		result.ErrorReason = fmt.Sprintf("HTTP %d (expected %s)", resp.StatusCode, expected)
 	}
@@ -160,7 +170,7 @@ func runPortCheck(site models.Site) CheckResult {
 	latency := time.Since(start)
 
 	if err != nil {
-		return CheckResult{SiteID: site.ID, Status: "DOWN", LatencyNs: latency.Nanoseconds(), ErrorReason: truncateError(err.Error(), 256)}
+		return CheckResult{SiteID: site.ID, Status: "DOWN", LatencyNs: latency.Nanoseconds(), ErrorReason: truncateError(err.Error(), maxErrorLength)}
 	}
 	_ = conn.Close()
 	return CheckResult{SiteID: site.ID, Status: "UP", LatencyNs: latency.Nanoseconds()}
@@ -174,10 +184,10 @@ func runDNSCheck(site models.Site) CheckResult {
 
 	server := site.DNSServer
 	if server == "" {
-		server = "1.1.1.1"
+		server = defaultDNSServer
 	}
 	if _, _, err := net.SplitHostPort(server); err != nil {
-		server = net.JoinHostPort(server, "53")
+		server = net.JoinHostPort(server, defaultDNSPort)
 	}
 
 	qtype := dns.TypeA
@@ -223,12 +233,12 @@ func siteTimeout(site models.Site) time.Duration {
 	if site.Timeout > 0 {
 		return time.Duration(site.Timeout) * time.Second
 	}
-	return 5 * time.Second
+	return defaultTimeout
 }
 
 func isCodeAccepted(code int, accepted string) bool {
 	if accepted == "" {
-		return code >= 200 && code < 300
+		return code >= defaultHTTPStatusMin && code < defaultHTTPStatusMax
 	}
 	for _, part := range strings.Split(accepted, ",") {
 		part = strings.TrimSpace(part)
diff --git a/internal/monitor/monitor.go b/internal/monitor/monitor.go
index 05df6f8..ac20972 100644
--- a/internal/monitor/monitor.go
+++ b/internal/monitor/monitor.go
@@ -138,7 +138,7 @@ func (e *Engine) AddLog(msg string) {
 }
 
 func (e *Engine) InitLogs() {
-	logs, err := e.db.LoadLogs(100)
+	logs, err := e.db.LoadLogs(maxLogEntries)
 	if err != nil {
 		return
 	}