lerko
a5fd3aec90
Thread context.Context from callers instead of creating context.Background() at every call site. Engine stores its lifecycle ctx for use by triggerAlert goroutines. TUI Model carries ctx for store operations in Cmd closures. CLI commands create a root ctx and thread it through openStore, seed functions, and init methods. Only two intentional context.Background() remain in non-root positions: engine constructor default (overridden by Start) and drainWrites (parent already cancelled at shutdown).
116 lines
3.1 KiB
Go
116 lines
3.1 KiB
Go
package main
|
|
|
|
import (
|
|
"context"
|
|
"crypto/ed25519"
|
|
"crypto/rand"
|
|
"errors"
|
|
"testing"
|
|
"time"
|
|
|
|
"gitea.lerkolabs.com/lerkolabs/uptop/internal/models"
|
|
"gitea.lerkolabs.com/lerkolabs/uptop/internal/store/storetest"
|
|
|
|
"github.com/charmbracelet/ssh"
|
|
gossh "golang.org/x/crypto/ssh"
|
|
)
|
|
|
|
// kcMockStore embeds BaseMock for default no-ops; only GetAllUsers is
|
|
// overridden because the tests mutate users/err between calls.
|
|
type kcMockStore struct {
|
|
storetest.BaseMock
|
|
users []models.User
|
|
err error
|
|
}
|
|
|
|
func (m *kcMockStore) GetAllUsers(_ context.Context) ([]models.User, error) { return m.users, m.err }
|
|
|
|
func testKey(t *testing.T) (string, ssh.PublicKey) {
|
|
t.Helper()
|
|
pub, _, err := ed25519.GenerateKey(rand.Reader)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
sk, err := gossh.NewPublicKey(pub)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
return string(gossh.MarshalAuthorizedKey(sk)), sk
|
|
}
|
|
|
|
func TestKeyCache_AllowsKnownDeniesUnknown(t *testing.T) {
|
|
authorized, known := testKey(t)
|
|
_, unknown := testKey(t)
|
|
kc := newKeyCache(&kcMockStore{users: []models.User{{PublicKey: authorized}}})
|
|
|
|
if !kc.IsAllowed(context.Background(), known) {
|
|
t.Error("known key denied")
|
|
}
|
|
if kc.IsAllowed(context.Background(), unknown) {
|
|
t.Error("unknown key allowed")
|
|
}
|
|
}
|
|
|
|
func TestKeyCache_RetainsKeysOnRefreshError(t *testing.T) {
|
|
authorized, known := testKey(t)
|
|
ms := &kcMockStore{users: []models.User{{PublicKey: authorized}}}
|
|
kc := newKeyCache(ms)
|
|
|
|
if !kc.IsAllowed(context.Background(), known) {
|
|
t.Fatal("known key denied on first refresh")
|
|
}
|
|
|
|
// DB goes down and the cache goes stale: a transient error must not lock
|
|
// every admin out — the previous key set stays in effect.
|
|
ms.err = errors.New("db down")
|
|
kc.mu.Lock()
|
|
kc.updated = time.Now().Add(-time.Hour)
|
|
kc.mu.Unlock()
|
|
|
|
if !kc.IsAllowed(context.Background(), known) {
|
|
t.Error("transient refresh error locked out a previously valid key")
|
|
}
|
|
}
|
|
|
|
func TestKeyCache_FailsClosedAfterInvalidate(t *testing.T) {
|
|
authorized, known := testKey(t)
|
|
ms := &kcMockStore{users: []models.User{{PublicKey: authorized}}}
|
|
kc := newKeyCache(ms)
|
|
|
|
if !kc.IsAllowed(context.Background(), known) {
|
|
t.Fatal("known key denied on first refresh")
|
|
}
|
|
|
|
// Revocation happened (Invalidate) and the DB is unreachable for the
|
|
// re-read: the revoked key must NOT keep working off the stale cache.
|
|
ms.err = errors.New("db down")
|
|
kc.Invalidate()
|
|
|
|
if kc.IsAllowed(context.Background(), known) {
|
|
t.Error("revoked key still allowed while DB is down — fails open")
|
|
}
|
|
}
|
|
|
|
func TestUserInvalidatingStore_DeleteDropsKeyCache(t *testing.T) {
|
|
authorized, known := testKey(t)
|
|
ms := &kcMockStore{users: []models.User{{PublicKey: authorized}}}
|
|
kc := newKeyCache(ms)
|
|
s := &userInvalidatingStore{Store: ms, kc: kc}
|
|
|
|
if !kc.IsAllowed(context.Background(), known) {
|
|
t.Fatal("known key denied on first refresh")
|
|
}
|
|
|
|
// Revoke the user; DB unreachable immediately after. The cached key must
|
|
// be gone the moment the delete returns.
|
|
if err := s.DeleteUser(context.Background(), 1); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
ms.users = nil
|
|
ms.err = errors.New("db down")
|
|
|
|
if kc.IsAllowed(context.Background(), known) {
|
|
t.Error("deleted user's key still allowed from stale cache")
|
|
}
|
|
}
|