chore(tui): delete dead braille code, hoist sparkWidth, stop resize flash #115

2026-06-12T12:21:58Z

lerko commented

2026-06-12 12:21:58 +00:00

Summary

Three TUI cleanup items from the review-findings backlog.

Delete dead braille code — braille.go + braille_test.go were only referenced by each other. -176 lines. Can be re-added when latency charts are built.
Hoist duplicate sparkWidth — const sparkWidth = 40 was defined independently in update.go and view_detail.go. Now a single detailSparkWidth package constant. Click-index resolution and rendering share one value.
Stop resize flash — tea.ClearScreen fired on every WindowSizeMsg, causing full-screen flash during continuous resizes. Removed. Manual ctrl+l clear kept.

Also verified: tickMsg type (item 4) was already fixed in a prior PR.

Test plan

go test -count=1 ./... — all pass
golangci-lint — 0 issues

## Summary Three TUI cleanup items from the review-findings backlog. 1. **Delete dead braille code** — `braille.go` + `braille_test.go` were only referenced by each other. -176 lines. Can be re-added when latency charts are built. 2. **Hoist duplicate sparkWidth** — `const sparkWidth = 40` was defined independently in `update.go` and `view_detail.go`. Now a single `detailSparkWidth` package constant. Click-index resolution and rendering share one value. 3. **Stop resize flash** — `tea.ClearScreen` fired on every `WindowSizeMsg`, causing full-screen flash during continuous resizes. Removed. Manual `ctrl+l` clear kept. Also verified: `tickMsg` type (item 4) was already fixed in a prior PR. ## Test plan - [x] `go test -count=1 ./...` — all pass - [x] `golangci-lint` — 0 issues

lerko added 1 commit 2026-06-12 12:21:59 +00:00

chore(tui): delete dead braille code, hoist sparkWidth, stop resize flash

CI / test (pull_request) Successful in 1m58s

Details

CI / lint (pull_request) Successful in 1m22s

Details

CI / vulncheck (pull_request) Successful in 1m1s

Details

13637ec216

1. Delete braille.go + braille_test.go — dead code, only referenced
   by its own test. Can be re-added when latency charts are built.

2. Hoist duplicate `const sparkWidth = 40` (update.go + view_detail.go)
   to package-level `detailSparkWidth`. Click-index resolution and
   rendering now share one constant.

3. Remove tea.ClearScreen on every resize — caused full-screen flash
   during continuous resizes. ctrl+l manual clear kept.

lerko merged commit 13637ec216 into main

2026-06-12 12:31:23 +00:00

lerko deleted branch fix/tui-cleanup

2026-06-12 12:31:23 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: lerkolabs/uptop#115