lerkolabs/uptop
1
1
Fork 0
Code Issues 17 Pull Requests Actions Packages Projects 2 Releases 4 Wiki Activity

fix(release): exclude rc tags from cliff tag_pattern so launch notes span full history #129

Merged
lerko merged 1 commits from fix/launch-notes-tag-pattern into main 2026-06-12 21:54:25 +00:00
Conversation 0 Commits 1 Files Changed 1
+7 -5
lerko commented 2026-06-12 21:47:48 +00:00
Owner
Copy Link
Copy Source

Follow-up to #127 — its ignore_tags approach was wrong: git-cliff drops rc-tagged commits from the next release's section rather than folding them forward. A simulated v0.1.0 rendered a header with zero commits (rc.3's 99-byte notes were the same symptom).

Fix: rc tags are excluded from tag_pattern entirely, so only final tags are section boundaries. Verified in a scratch clone:

  • simulated v0.1.0: 8.8KB, full history from initial commit
  • rc-only state (what release runs see on an rc tag): [Unreleased] with the full pending span

No workflow changes needed — git-cliff --current behaves correctly for both tag styles. Last known pipeline defect; after this, v0.1.0 needs no rc.5 (notes generation is config-only, exercised locally).

Follow-up to #127 — its `ignore_tags` approach was wrong: git-cliff drops rc-tagged commits from the next release's section rather than folding them forward. A simulated `v0.1.0` rendered a header with **zero commits** (rc.3's 99-byte notes were the same symptom). Fix: rc tags are excluded from `tag_pattern` entirely, so only final tags are section boundaries. Verified in a scratch clone: - simulated `v0.1.0`: 8.8KB, full history from initial commit - rc-only state (what release runs see on an rc tag): `[Unreleased]` with the full pending span No workflow changes needed — `git-cliff --current` behaves correctly for both tag styles. Last known pipeline defect; after this, v0.1.0 needs no rc.5 (notes generation is config-only, exercised locally).
lerko added 1 commit 2026-06-12 21:47:49 +00:00
fix(release): exclude rc tags from cliff tag_pattern so launch notes span full history
CI / test (pull_request) Successful in 1m48s
Details
CI / lint (pull_request) Successful in 1m11s
Details
CI / vulncheck (pull_request) Successful in 51s
Details
eff67332aa 
ignore_tags drops rc-tagged commits from the final tag's section instead
of folding them forward — a simulated v0.1.0 rendered zero commits.
Excluding rc tags from tag_pattern makes finals span back to the last
real tag (full history for v0.1.0, verified 8.8KB in a scratch clone)
and rc tags render [Unreleased] with everything pending.
lerko merged commit eff67332aa into main 2026-06-12 21:54:25 +00:00
lerko deleted branch fix/launch-notes-tag-pattern 2026-06-12 21:54:25 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 distribution
Packaging, publishing, branding
 feature
New functionality
 polish
UX/visual refinement
 refactor
Code quality, no behavior change
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
lerko (Tyler Koenig)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lerkolabs/uptop#129
Delete Branch "fix/launch-notes-tag-pattern"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?