lerkolabs/uptop
1
1
Fork 0
Code Issues 17 Pull Requests Actions 1 Packages Projects 2 Releases 5 Wiki Activity

fix: resolve 4 tag-blocking issues for v0.1.0 #133

Merged
lerko merged 1 commits from fix/v010-tag-blockers into main 2026-06-17 17:55:52 +00:00
Conversation 0 Commits 1 Files Changed 8
+86 -13
lerko commented 2026-06-17 00:33:50 +00:00
Owner
Copy Link
Copy Source

Summary

Fixes the 4 tag-blocking issues from the release-consistency review that must land before v0.1.0:

  1. README quick start — added UPTOP_ADMIN_KEY so SSH works on fresh DB
  2. apply --dry-run broken — assign placeholder IDs for new alerts/groups so resolveAlertID succeeds when monitors reference not-yet-created alerts
  3. deploy/*.yml broken build contexts — user-facing compose files switched to image: lerkolabs/uptop:latest, dev compose context fixed to ..
  4. CONTRIBUTING.md — fixed go run cmd/uptop/main.go → go run ./cmd/uptop (doesn't compile as single-file path)

Test plan

  • TestApplyDryRunNewAlertAndMonitor — new alert + monitor referencing it, dry-run succeeds
  • TestApplyDryRunNewGroupWithChildren — new alert + group + child, dry-run succeeds
  • All 28 existing config tests pass, zero regressions
## Summary Fixes the 4 tag-blocking issues from the release-consistency review that must land before `v0.1.0`: 1. **README quick start** — added `UPTOP_ADMIN_KEY` so SSH works on fresh DB 2. **`apply --dry-run` broken** — assign placeholder IDs for new alerts/groups so `resolveAlertID` succeeds when monitors reference not-yet-created alerts 3. **`deploy/*.yml` broken build contexts** — user-facing compose files switched to `image: lerkolabs/uptop:latest`, dev compose context fixed to `..` 4. **CONTRIBUTING.md** — fixed `go run cmd/uptop/main.go` → `go run ./cmd/uptop` (doesn't compile as single-file path) ## Test plan - [x] `TestApplyDryRunNewAlertAndMonitor` — new alert + monitor referencing it, dry-run succeeds - [x] `TestApplyDryRunNewGroupWithChildren` — new alert + group + child, dry-run succeeds - [x] All 28 existing config tests pass, zero regressions
lerko added 1 commit 2026-06-17 00:33:50 +00:00
fix: resolve 4 tag-blocking issues for v0.1.0
CI / test (pull_request) Successful in 1m43s
Details
CI / lint (pull_request) Successful in 1m11s
Details
CI / vulncheck (pull_request) Successful in 51s
Details
c2bfa5ad82 
- README/CONTRIBUTING quick start: add UPTOP_ADMIN_KEY so SSH works on
  fresh DB, fix single-file go run path that doesn't compile
- apply --dry-run: assign placeholder IDs for new alerts and groups so
  resolveAlertID succeeds when monitors reference not-yet-created alerts
- deploy/*.yml: switch user-facing compose files from broken build
  context to image: lerkolabs/uptop:latest, fix dev context to ..
lerko merged commit c2bfa5ad82 into main 2026-06-17 17:55:52 +00:00
lerko deleted branch fix/v010-tag-blockers 2026-06-17 17:55:52 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 distribution
Packaging, publishing, branding
 feature
New functionality
 polish
UX/visual refinement
 refactor
Code quality, no behavior change
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
lerko (Tyler Koenig)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lerkolabs/uptop#133
Delete Branch "fix/v010-tag-blockers"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?