fix: resolve 17 release-consistency findings #137

Merged
lerko merged 2 commits from fix/release-consistency-batch into main 2026-06-20 16:10:15 +00:00
Owner

Summary

Batch fix for documentation, Docker/deploy, and cosmetic issues from the release-consistency audit (2026-06-12).

Documentation (7):

  • Fix CI badge href to /actions (was 404 on Gitea)
  • Add UPTOP_METRICS_PUBLIC + UPTOP_MAINT_RETENTION to README env table
  • Note metrics auth requirement in features list
  • Fix clustering.md: fail-closed wording, mark AGG_STRATEGY/NODE_REGION optional
  • Fix .env.example: wording (no .env loader), add TRUSTED_PROXIES + MAINT_RETENTION
  • Add CLI help/usage with subcommand listing, accept serve/help/-h/-version
  • Clarify -db-type flag help text (sqlite or postgres)

Docker/deploy (7):

  • Add EXPOSE 8080 to Dockerfile
  • Remove dead LIPGLOSS_RENDERER_HAS_DARK_BACKGROUND env from Dockerfile
  • Exempt /api/health from cluster auth (fixes Docker HEALTHCHECK 401)
  • Add sysctls for unprivileged ping to all compose files
  • Disable healthcheck on probe compose services (no HTTP server in probe mode)
  • Remove stale "(Phase 4)" comment from dev compose
  • Add data/ to .gitignore (compose volume artifact)

Cosmetic (3):

  • Fix bug_report.yaml: SemVer placeholder, remove nonexistent serve subcommand

Test plan

  • go build ./... passes
  • go test ./... all green (updated health endpoint test)
  • golangci-lint zero issues
## Summary Batch fix for documentation, Docker/deploy, and cosmetic issues from the release-consistency audit (2026-06-12). **Documentation (7):** - Fix CI badge href to `/actions` (was 404 on Gitea) - Add `UPTOP_METRICS_PUBLIC` + `UPTOP_MAINT_RETENTION` to README env table - Note metrics auth requirement in features list - Fix clustering.md: fail-closed wording, mark `AGG_STRATEGY`/`NODE_REGION` optional - Fix .env.example: wording (no .env loader), add `TRUSTED_PROXIES` + `MAINT_RETENTION` - Add CLI help/usage with subcommand listing, accept `serve`/`help`/`-h`/`-version` - Clarify `-db-type` flag help text (sqlite or postgres) **Docker/deploy (7):** - Add `EXPOSE 8080` to Dockerfile - Remove dead `LIPGLOSS_RENDERER_HAS_DARK_BACKGROUND` env from Dockerfile - Exempt `/api/health` from cluster auth (fixes Docker HEALTHCHECK 401) - Add `sysctls` for unprivileged ping to all compose files - Disable healthcheck on probe compose services (no HTTP server in probe mode) - Remove stale "(Phase 4)" comment from dev compose - Add `data/` to .gitignore (compose volume artifact) **Cosmetic (3):** - Fix bug_report.yaml: SemVer placeholder, remove nonexistent `serve` subcommand ## Test plan - [x] `go build ./...` passes - [x] `go test ./...` all green (updated health endpoint test) - [x] `golangci-lint` zero issues
lerko added 2 commits 2026-06-20 00:41:01 +00:00
Documentation:
- Fix CI badge href to /actions (was 404 on Gitea)
- Add UPTOP_METRICS_PUBLIC + UPTOP_MAINT_RETENTION to README env table
- Link maintenance retention to env var name in data retention section
- Note metrics auth requirement in features list
- Fix clustering.md: fail-closed wording, mark AGG_STRATEGY/NODE_REGION optional
- Fix .env.example: wording (no .env loader), add TRUSTED_PROXIES + MAINT_RETENTION
- Add CLI help/usage with subcommand listing, accept serve/help/-h/-version

Docker/deploy:
- Add EXPOSE 8080 to Dockerfile
- Remove dead LIPGLOSS_RENDERER_HAS_DARK_BACKGROUND env
- Exempt /api/health from cluster auth (fixes Docker HEALTHCHECK 401)
- Add sysctls for unprivileged ping to all compose files

Cosmetic:
- Fix bug_report.yaml: SemVer placeholder, remove nonexistent serve subcommand
fix: 4 additional release-consistency findings
CI / test (pull_request) Successful in 1m46s
CI / lint (pull_request) Successful in 1m11s
CI / vulncheck (pull_request) Successful in 51s
dbd519c121
- Disable healthcheck on probe compose services (no HTTP server)
- Remove stale "(Phase 4)" comment from dev compose
- Add data/ to .gitignore (compose volume creates deploy/data)
- Clarify -db-type flag help text (sqlite or postgres)
lerko merged commit dbd519c121 into main 2026-06-20 16:10:15 +00:00
lerko deleted branch fix/release-consistency-batch 2026-06-20 16:10:15 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lerkolabs/uptop#137