lerkolabs/uptop
1
1
Fork 0
Code Issues 5 Pull Requests 1 Actions Packages Projects 1 Releases 1 Wiki Activity

fix(tui): correct delete confirm labels, normalize help text #160

Merged
lerko merged 1 commits from fix/pre-announce-polish into main 2026-06-29 13:50:28 +00:00
Conversation 0 Commits 1 Files Changed 9
+22 -23
lerko commented 2026-06-29 13:45:58 +00:00
Owner
Copy Link
Copy Source

Summary

  • Fix delete confirmation bug — dialog used wrong magic numbers (1, 4, 5) instead of tab/section constants. Maintenance window deletes showed "alert", Settings deletes showed "monitor". Now correctly maps via tabMaint/tabSettings + settingsSection.
  • Normalize [q/Esc] Back across all views — detail inline, fullscreen logs, SLA header, history header. Was inconsistent mix of [esc] Close, [Esc] Back, [q] Back.
  • Cleanup — extract detailKeys() to deduplicate help string, remove dead maxSections variable, add nodes empty state hint, use models.Status constants in siteOrder, delete orphaned assets/theme.png.

Test plan

  • go build passes
  • go test passes
  • golangci-lint 0 issues
  • Visual TUI review via zellij: delete confirm dialog, detail panel, fullscreen logs, nodes empty state all verified
## Summary - **Fix delete confirmation bug** — dialog used wrong magic numbers (1, 4, 5) instead of tab/section constants. Maintenance window deletes showed "alert", Settings deletes showed "monitor". Now correctly maps via tabMaint/tabSettings + settingsSection. - **Normalize [q/Esc] Back across all views** — detail inline, fullscreen logs, SLA header, history header. Was inconsistent mix of [esc] Close, [Esc] Back, [q] Back. - **Cleanup** — extract detailKeys() to deduplicate help string, remove dead maxSections variable, add nodes empty state hint, use models.Status constants in siteOrder, delete orphaned assets/theme.png. ## Test plan - [x] go build passes - [x] go test passes - [x] golangci-lint 0 issues - [x] Visual TUI review via zellij: delete confirm dialog, detail panel, fullscreen logs, nodes empty state all verified
lerko added 1 commit 2026-06-29 13:45:59 +00:00
fix(tui): correct delete confirm labels, normalize help text
CI / test (pull_request) Successful in 1m52s
Details
CI / lint (pull_request) Successful in 1m11s
Details
CI / vulncheck (pull_request) Successful in 56s
Details
7ce5af5bf6 
Delete confirmation dialog used wrong magic numbers for entity kind
mapping — maintenance windows showed as "alert", settings deletions
showed as "monitor". Now uses tab/section constants to match correctly.

Also: consistent [q/Esc] Back across all views (detail inline, logs,
SLA, history headers), extract detailKeys(), remove dead maxSections
variable, add nodes empty state hint, use models.Status constants in
siteOrder, delete orphaned theme.png.
lerko merged commit 7ce5af5bf6 into main 2026-06-29 13:50:28 +00:00
lerko deleted branch fix/pre-announce-polish 2026-06-29 13:50:28 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 distribution
Packaging, publishing, branding
 feature
New functionality
 github
Forwarded from GitHub
 polish
UX/visual refinement
 refactor
Code quality, no behavior change
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
lerko (Tyler Koenig)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lerkolabs/uptop#160
Delete Branch "fix/pre-announce-polish"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?