fix(monitor): inject time into ComputeDailyBreakdown #91

Merged

lerko merged 1 commits from fix/sla-daily-breakdown-time into main 2026-06-05 14:46:45 +00:00

Conversation 0 Commits 1 Files Changed 3

+5 -5

lerko commented 2026-06-05 01:30:19 +00:00

Owner

Copy Link

Copy Source

TestComputeDailyBreakdown failed when CI ran near midnight — outage events fell in previous day's bucket, making today show 100% uptime.

• ComputeDailyBreakdown now accepts a now time.Time parameter instead of calling time.Now() internally
• Test uses a fixed time (15:00 UTC) so it passes regardless of when CI runs

TestComputeDailyBreakdown failed when CI ran near midnight — outage events fell in previous day's bucket, making today show 100% uptime. - `ComputeDailyBreakdown` now accepts a `now time.Time` parameter instead of calling `time.Now()` internally - Test uses a fixed time (15:00 UTC) so it passes regardless of when CI runs

lerko added 1 commit 2026-06-05 01:30:20 +00:00

fix(monitor): inject time into ComputeDailyBreakdown for testability ... c471a72ff5

Test failed near midnight when outage events fell in previous day's
bucket. Accept a now parameter instead of calling time.Now() internally.

lerko merged commit c471a72ff5 into main 2026-06-05 14:46:45 +00:00

lerko deleted branch fix/sla-daily-breakdown-time 2026-06-05 14:46:45 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

Something isn't working

distribution

Packaging, publishing, branding

feature

New functionality

polish

UX/visual refinement

refactor

Code quality, no behavior change

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

lerko (Tyler Koenig)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: lerkolabs/uptop#91