lerkolabs/uptop
1
1
Fork 0
Code Issues 17 Pull Requests 1 Actions Packages Projects 2 Releases 1 Wiki Activity

refactor: fix bare errors in tests, extract magic numbers #93

Merged
lerko merged 2 commits from refactor/test-errors-and-constants into main 2026-06-05 20:41:15 +00:00
Conversation 0 Commits 2 Files Changed 3
+67 -21
lerko commented 2026-06-05 20:32:07 +00:00
Owner
Copy Link
Copy Source

Two small refactors bundled:

  • #74 — All 13 bare _ error discards in sqlstore_test.go now check errors with t.Fatalf
  • #75 — Magic numbers in checker.go and monitor.go extracted into named constants (maxErrorLength, defaultAcceptedCodes, defaultHTTPStatus{Min,Max}, defaultTimeout, defaultDNSServer, defaultDNSPort)

Closes #74, closes #75

Two small refactors bundled: - **#74** — All 13 bare `_` error discards in `sqlstore_test.go` now check errors with `t.Fatalf` - **#75** — Magic numbers in `checker.go` and `monitor.go` extracted into named constants (maxErrorLength, defaultAcceptedCodes, defaultHTTPStatus{Min,Max}, defaultTimeout, defaultDNSServer, defaultDNSPort) Closes #74, closes #75
lerko added 2 commits 2026-06-05 20:32:55 +00:00
refactor(monitor): extract magic numbers into named constants d53a4e6ac3 
Closes #75
refactor(store): check all discarded errors in sqlstore_test.go
CI / test (pull_request) Successful in 2m37s
Details
CI / lint (pull_request) Successful in 56s
Details
CI / vulncheck (pull_request) Successful in 46s
Details
cc139bdb73 
Closes #74
lerko force-pushed refactor/test-errors-and-constants from e5b76fd187 to cc139bdb73 2026-06-05 20:32:55 +00:00 Compare
lerko merged commit cc139bdb73 into main 2026-06-05 20:41:15 +00:00
lerko deleted branch refactor/test-errors-and-constants 2026-06-05 20:41:15 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 distribution
Packaging, publishing, branding
 feature
New functionality
 polish
UX/visual refinement
 refactor
Code quality, no behavior change
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
lerko (Tyler Koenig)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lerkolabs/uptop#93
Delete Branch "refactor/test-errors-and-constants"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?